Fix incomplete Issue #110 - change PREMode default to NOT_SET#1122
Merged
yspolyakov merged 1 commit intodevfrom Feb 16, 2026
Merged
Fix incomplete Issue #110 - change PREMode default to NOT_SET#1122yspolyakov merged 1 commit intodevfrom
yspolyakov merged 1 commit intodevfrom
Conversation
Fixes #110 The original fix in commit 64ed308 never worked because PREMode defaulted to INDCPA, not NOT_SET. This caused GetParamsPK() to always return Q×P basis for HYBRID, even when PRE is not needed. Changes: - Set default PREMode to NOT_SET in gen-cryptocontext-params-defaults.h - Update pre-buffer.cpp to explicitly set PREMode=INDCPA
Collaborator
|
@dsuponitskiy, please find the PR at #1124. |
yspolyakov
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces this original PR
Fixes #110
The original fix in commit 64ed308 never worked because PREMode defaulted to INDCPA, not NOT_SET. This caused GetParamsPK() to always return Q×P basis for HYBRID, even when PRE is not needed.
Changes: