chore: regenerate package-lock.json for verawood#678
Conversation
The lock file on release/verawood references pre-Verawood transitive deps (parse5@6, whatwg-url@8.7.0, acorn@7.4.1, jsdom-related packages, etc.) that the current package.json no longer pulls in. This causes 'npm ci' to fail with 'Missing: <pkg> from lock file' errors during MFE image builds for the Verawood sandbox. Regenerated via 'npm install' against the current package.json.
|
Thanks for the pull request, @ahmed-arb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/verawood #678 +/- ##
=================================================
Coverage 86.00% 86.00%
=================================================
Files 27 27
Lines 443 443
Branches 104 102 -2
=================================================
Hits 381 381
Misses 61 61
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The package-lock is not wrong. tutor-mfe@verawood just needs to be synced with main. |
Summary
The
package-lock.jsononrelease/verawoodis out of sync withpackage.json. It still references pre-Verawood transitive deps (parse5@6,whatwg-url@8.7.0,acorn@7.4.1,jsdom@16-era packages,domexception@2, etc.) that the currentpackage.jsonno longer pulls in.This causes
npm ci(clean-install) to fail during MFE image builds with errors like:This is blocking the Edly Verawood sandbox build (tracked in overhangio/tutor#1370). The learner-record MFE is registered by
tutor-credentialsand built as part of theopenedx-mfeDocker image.Change
Regenerated
package-lock.jsonvianpm installagainst the currentpackage.json. Nopackage.jsonchanges.LLM Usage:
Created with the help of Claude code