Skip to content

chore: regenerate package-lock.json for verawood#678

Closed
ahmed-arb wants to merge 1 commit into
openedx:release/verawoodfrom
edly-io:ahmed-arb/regenerate-verawood-lockfile
Closed

chore: regenerate package-lock.json for verawood#678
ahmed-arb wants to merge 1 commit into
openedx:release/verawoodfrom
edly-io:ahmed-arb/regenerate-verawood-lockfile

Conversation

@ahmed-arb
Copy link
Copy Markdown

@ahmed-arb ahmed-arb commented May 5, 2026

Summary

The package-lock.json on release/verawood is out of sync with package.json. It still references pre-Verawood transitive deps (parse5@6, whatwg-url@8.7.0, acorn@7.4.1, jsdom@16-era packages, domexception@2, etc.) that the current package.json no longer pulls in.

This causes npm ci (clean-install) to fail during MFE image builds with errors like:

npm error Missing: domexception@2.0.1 from lock file
npm error Missing: parse5@6.0.1 from lock file
npm error Missing: acorn@7.4.1 from lock file
... [many more]

This is blocking the Edly Verawood sandbox build (tracked in overhangio/tutor#1370). The learner-record MFE is registered by tutor-credentials and built as part of the openedx-mfe Docker image.

Change

Regenerated package-lock.json via npm install against the current package.json. No package.json changes.

LLM Usage:

Created with the help of Claude code

The lock file on release/verawood references pre-Verawood transitive deps
(parse5@6, whatwg-url@8.7.0, acorn@7.4.1, jsdom-related packages, etc.)
that the current package.json no longer pulls in. This causes 'npm ci'
to fail with 'Missing: <pkg> from lock file' errors during MFE image
builds for the Verawood sandbox.

Regenerated via 'npm install' against the current package.json.
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @ahmed-arb!

This repository is currently maintained by @jajjibhai008.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 5, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (3c1b630) to head (2a2eb19).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/verawood     #678   +/-   ##
=================================================
  Coverage             86.00%   86.00%           
=================================================
  Files                    27       27           
  Lines                   443      443           
  Branches                104      102    -2     
=================================================
  Hits                    381      381           
  Misses                   61       61           
  Partials                  1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbrandes
Copy link
Copy Markdown
Contributor

The package-lock is not wrong. tutor-mfe@verawood just needs to be synced with main.

@arbrandes arbrandes closed this May 5, 2026
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants