-
Notifications
You must be signed in to change notification settings - Fork 84
docs: Update enable_notifications.rst with initialization details #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,22 +32,29 @@ Enable the plugin in your Tutor environment: | |
|
|
||
| tutor plugins enable notifications | ||
|
|
||
| When enabled, the plugin automatically: | ||
| When enabled, the plugin requires an **initialization step** to enable notifications: | ||
|
|
||
| - Enables the following waffle flags: | ||
| - After enabling the plugin, you must run the following command to properly set up waffle flags and environment variables for the notifications service. Replace `[do/local/k8s]` with the appropriate option for your deployment environment: | ||
|
|
||
| - ``notifications.enable_notifications`` | ||
| - ``notifications.enable_email_notifications`` | ||
| .. code-block:: bash | ||
|
|
||
| - Sets the required environment variables for the notifications service | ||
| tutor dev [do/local/k8s] init --limit notifications | ||
|
|
||
| - ``SHOW_EMAIL_CHANNEL`` (defaults to TRUE) | ||
| - ``SHOW_PUSH_CHANNEL`` (defaults to FALSE) | ||
| This step ensures that the following are set: | ||
|
|
||
| - The waffle flags: | ||
|
|
||
| - ``notifications.enable_notifications`` | ||
| - ``notifications.enable_email_notifications`` | ||
|
|
||
| - The required environment variables for the notifications service: | ||
|
|
||
| - ``SHOW_EMAIL_CHANNEL`` (defaults to TRUE) | ||
| - ``SHOW_PUSH_CHANNEL`` (defaults to FALSE) | ||
|
|
||
| .. important:: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line has extra spacing before |
||
|
|
||
| After enabling the notifications plugin, site operators **must rebuild the | ||
| MFE image** for the notification tray to appear in the user interface. | ||
| After enabling the notifications plugin and completing the initialization step as mentioned above, site operators must rebuild the MFE image for the notification tray to appear in the user interface. | ||
|
|
||
| Rebuild the MFE image: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command reads as if
devis fixed and[do/local/k8s]is the placeholder, which would lead operators to run an invalid Tutor command. Existing Tutor patterns use the environment first, then the action, for exampletutor local do init --limit=notificationsortutor k8s do init --limit=notifications. I would replace this with two explicit examples rather than a nested placeholder.