Skip to content

Make the opening of files deterministic#478

Merged
agarny merged 3 commits intoopencor:mainfrom
agarny:issue474
Mar 25, 2026
Merged

Make the opening of files deterministic#478
agarny merged 3 commits intoopencor:mainfrom
agarny:issue474

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Mar 25, 2026

Fixes #474.

Copilot AI review requested due to automatic review settings March 25, 2026 06:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #474 by making multi-file opens deterministic (e.g., drag & drop), ensuring tabs are opened in the original input order regardless of individual file load times.

Changes:

  • Introduces an openFiles() pipeline that processes files in parallel but opens tabs sequentially in original order.
  • Refactors file-opening logic into processFile() and updates ContentsComponent.openFile() to be async with a short UI-initialisation wait between opens.
  • Adds waitForNextAnimationFrame() helper and bumps package versions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/renderer/src/components/OpenCOR.vue Adds processFile() and openFiles() to enforce deterministic tab opening order.
src/renderer/src/components/ContentsComponent.vue Makes openFile() async and adds a small UI-settle delay to avoid tab/view init issues when opening multiple files.
src/renderer/src/common/common.ts Adds waitForNextAnimationFrame() utility; minor sleep() formatting change.
src/renderer/package.json Version bump.
package.json Version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit 49518cd into opencor:main Mar 25, 2026
13 checks passed
@agarny agarny deleted the issue474 branch March 25, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the opening of files deterministic

2 participants