Graph Panel widget: improve graph panel resizing and visibility handling#477
Merged
agarny merged 2 commits intoopencor:mainfrom Mar 25, 2026
Merged
Graph Panel widget: improve graph panel resizing and visibility handling#477agarny merged 2 commits intoopencor:mainfrom
agarny merged 2 commits intoopencor:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the Graph Panel widget’s behavior around resizing/margin measurement and removes the previous visibility-based rendering workaround (per #473), while bumping package versions.
Changes:
- Remove
isVisible/visible/invisiblehandling fromGraphPanelWidgetand simplify initial rendering. - Add a guard to avoid margin measurement when the plot container has zero size.
- Bump renderer and root package versions from
0.20260325.0to0.20260325.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/renderer/src/components/widgets/GraphPanelWidget.vue | Removes visibility gating, adds size guard for margin measurement, and triggers resize after Plotly.react() to keep alignment. |
| src/renderer/package.json | Version bump. |
| package.json | Version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #473.