Skip to content

Cleaning up#476

Merged
agarny merged 4 commits intoopencor:mainfrom
agarny:cleaning-up
Mar 25, 2026
Merged

Cleaning up#476
agarny merged 4 commits intoopencor:mainfrom
agarny:cleaning-up

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Mar 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 25, 2026 01:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR “cleans up” the TypeScript/Vue/Electron build setup by simplifying TS configs, switching many internal imports to extensionless specifiers, and updating the library type-generation approach.

Changes:

  • Consolidates/adjusts TypeScript project configs (solution refs, includes, NodeNext settings, output dirs).
  • Removes .ts extensions from many internal relative imports across renderer/common/libopencor and Electron main/preload.
  • Replaces the renderer library type publishing flow (removes index.d.ts + copy script; adds a dedicated vue-tsc declaration emit config).

Reviewed changes

Copilot reviewed 42 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsconfig.web.json Reworks web TS project settings and include globs.
tsconfig.node.json Updates Node TS project settings, output dir, and include globs.
tsconfig.json Updates solution-level compiler options and project references.
tsconfig.app.json Simplifies app tsconfig to extend Vue DOM base and narrows includes.
src/renderer/tsconfig.lib.types.json New config to emit declaration-only types for the published renderer library.
src/renderer/tsconfig.json Simplifies renderer tsconfig to extend Vue DOM base.
src/renderer/src/libopencor/*.ts Switches internal imports to extensionless specifiers.
src/renderer/src/components/**/*.vue Switches internal imports to extensionless specifiers.
src/renderer/src/common/*.ts Switches internal imports to extensionless specifiers.
src/preload/index.ts Switches type imports to extensionless specifiers; removes TS suppression for native addon import.
src/main/*.ts Switches internal imports to extensionless specifiers.
src/renderer/scripts/copy.indexdts.js Removes now-obsolete type-copying script.
src/renderer/index.d.ts Removes now-obsolete hand-written type entrypoint.
src/renderer/package.json Updates version and changes build:lib to emit declarations via vue-tsc.
package.json Updates version and dependency versions.
bun.lock / src/renderer/bun.lock Lockfile updates for the dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit d1de1ba into opencor:main Mar 25, 2026
13 checks passed
@agarny agarny deleted the cleaning-up branch March 25, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants