Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR “cleans up” the TypeScript/Vue/Electron build setup by simplifying TS configs, switching many internal imports to extensionless specifiers, and updating the library type-generation approach.
Changes:
- Consolidates/adjusts TypeScript project configs (solution refs, includes, NodeNext settings, output dirs).
- Removes
.tsextensions from many internal relative imports across renderer/common/libopencor and Electron main/preload. - Replaces the renderer library type publishing flow (removes
index.d.ts+ copy script; adds a dedicatedvue-tscdeclaration emit config).
Reviewed changes
Copilot reviewed 42 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.web.json | Reworks web TS project settings and include globs. |
| tsconfig.node.json | Updates Node TS project settings, output dir, and include globs. |
| tsconfig.json | Updates solution-level compiler options and project references. |
| tsconfig.app.json | Simplifies app tsconfig to extend Vue DOM base and narrows includes. |
| src/renderer/tsconfig.lib.types.json | New config to emit declaration-only types for the published renderer library. |
| src/renderer/tsconfig.json | Simplifies renderer tsconfig to extend Vue DOM base. |
| src/renderer/src/libopencor/*.ts | Switches internal imports to extensionless specifiers. |
| src/renderer/src/components/**/*.vue | Switches internal imports to extensionless specifiers. |
| src/renderer/src/common/*.ts | Switches internal imports to extensionless specifiers. |
| src/preload/index.ts | Switches type imports to extensionless specifiers; removes TS suppression for native addon import. |
| src/main/*.ts | Switches internal imports to extensionless specifiers. |
| src/renderer/scripts/copy.indexdts.js | Removes now-obsolete type-copying script. |
| src/renderer/index.d.ts | Removes now-obsolete hand-written type entrypoint. |
| src/renderer/package.json | Updates version and changes build:lib to emit declarations via vue-tsc. |
| package.json | Updates version and dependency versions. |
| bun.lock / src/renderer/bun.lock | Lockfile updates for the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.