InputScientificNumber: add support for up/down buttons#472
InputScientificNumber: add support for up/down buttons#472agarny merged 3 commits intoopencor:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds “spin” (up/down) controls to InputScientificNumber so scalar simulation inputs can be incremented/decremented by the configured step value (Fixes #467).
Changes:
- Pass
min,max, andstepfromInputWidgetintoInputScientificNumber. - Extend
InputScientificNumberwith increment/decrement buttons, keyboard handling (ArrowUp/ArrowDown/Home/End), and press-and-hold repeat. - Introduce shared spin timing constants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/renderer/src/components/widgets/InputWidget.vue | Wires min/max/step into InputScientificNumber to enable bounded stepping. |
| src/renderer/src/components/widgets/InputScientificNumber.vue | Implements the spinner UI/logic, focus styling, and repeat-spin behavior. |
| src/renderer/src/common/constants.ts | Adds repeat-spin timing constants used by the new spinner behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agarny
force-pushed
the
issue467
branch
2 times, most recently
from
dcb91a3 to
6becb8f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agarny
force-pushed
the
issue467
branch
3 times, most recently
from
0e85444 to
898d45a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agarny
force-pushed
the
issue467
branch
2 times, most recently
from
b395072 to
5881bab
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #467.