This repository was archived by the owner on Jan 15, 2026. It is now read-only.
image: generate useful config#77
Open
cyphar wants to merge 1 commit intoopencontainers:masterfrom
cyphar:generate-valid-config
Open
image: generate useful config#77cyphar wants to merge 1 commit intoopencontainers:masterfrom cyphar:generate-valid-config
cyphar wants to merge 1 commit intoopencontainers:masterfrom
cyphar:generate-valid-config
Conversation
The previous config generation produced a config which would cause runC to run the container using the host filesystem (with no namespaces set up). While we should try to be as agnostic as possible, we don't want to generate config.json payloads that are known to be bad (and useless). Signed-off-by: Aleksa Sarai <asarai@suse.com>
wking
reviewed
Nov 6, 2016
| s.Version = specs.Version | ||
| // we should at least apply the default spec, otherwise this is totally useless | ||
| s.Process.Terminal = true | ||
| // TODO: Get this default from somewhere, rather than hardcoding it here. |
Contributor
There was a problem hiding this comment.
I suggest you get the default from a vendored runtime-tools/generate.
Member
Author
There was a problem hiding this comment.
I ended up implementing cyphar/umoci#13 so I'll probably end up just merging that here and dropping the old code.
Member
|
I'm +1 with this |
Member
|
I'm +1 for this, but it looks like |
|
@cyphar I passed the test after I rebased it. Can you rebase it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous config generation produced a config which would cause runC
to run the container using the host filesystem (with no namespaces set
up). While we should try to be as agnostic as possible, we don't want to
generate config.json payloads that are known to be bad (and useless).
Fixes #76
Signed-off-by: Aleksa Sarai asarai@suse.com