Skip to content

Make time filtering in PVNet datasets more flexible#412

Open
dfulu wants to merge 2 commits intomainfrom
cross_val_time_slice
Open

Make time filtering in PVNet datasets more flexible#412
dfulu wants to merge 2 commits intomainfrom
cross_val_time_slice

Conversation

@dfulu
Copy link
Copy Markdown
Member

@dfulu dfulu commented Apr 14, 2026

Pull Request

Description

This pull request enhances the PVNet dataset classes by allowing users to filter data using multiple time periods rather than just a single start and end time. It introduces a new utility function get_time_periods_mask() for time period masking and updates both the dataset logic and associated tests to support and validate this more flexible approach.

This makes it easier to perform cross-validation with the dataset. However, note that this is a breaking change and will require corresponding changes in PVNet

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Copy Markdown
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants