fix(provider): classify stdout provider failures#99
Open
rohitjavvadi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provider subprocess failures can put their actionable error text on stdout instead of stderr. The failure message already used stderr-or-stdout, but the exit-code classifier only looked at stderr, so stdout-only auth, API-key, scope, quota, or rate-limit failures were reported as generic provider failures.
This updates the classifier to inspect both streams, keeps the existing single-message path compatible, and narrows the matching so benign generated text such as
author,oauth,authority, or rate-limit policy discussion does not get treated as a provider failure category.Verification
./node_modules/.bin/vitest run src/provider.test.ts./node_modules/.bin/vitest run./node_modules/.bin/tsc -p tsconfig.json --noEmit./node_modules/.bin/oxlint . --config oxlint.json./node_modules/.bin/oxfmt --check src/provider.ts src/provider.test.tsgit diff --check./node_modules/.bin/tsc -p tsconfig.build.json