Skip to content

fix(mapper): map Fastify plugin callback routes #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitjavvadi wants to merge 2 commits into
base: main
Choose a base branch
from
+428 −14
Open

fix(mapper): map Fastify plugin callback routes #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29e3458
fix(mapper): map Fastify plugin callback routes
rohitjavvadi May 18, 2026
56b98f2
fix(mapper): handle fastify plugin aliases
rohitjavvadi May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions src/mapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,12 +1912,95 @@ describe("mapFeatures", () => {
root,
"src/fastify-plugin.ts",
[
"import fastifyPlugin from 'fastify-plugin';",
"import fp from 'fastify-plugin';",
"import cjsPlugin = require('fastify-plugin');",
"import { FastifyInstance } from 'fastify';",
"",
"export async function routes(fastify: FastifyInstance) {",
" fastify.get('/plugin-users', listPluginUsers);",
"}",
"export async function appRoutes(app: FastifyInstance) {",
" app.get('/plugin-app-users', listPluginAppUsers);",
"}",
"const app = createHttpServer();",
"app.get('/not-plugin-app-typed', ignoredApp);",
"export const serverRoutes = fastifyPlugin(async function routes(server) {",
" server.get('/plugin-server-users', listPluginServerUsers);",
"});",
"export const arrowRoutes = fastifyPlugin(async (app) => {",
" app.get('/plugin-arrow-users', listPluginArrowUsers);",
"});",
"export const aliasedRoutes = fp(async (app) => {",
" app.get('/plugin-aliased-users', listPluginAliasedUsers);",
"});",
"type PluginOptions = { prefix: string };",
"export const genericRoutes = fastifyPlugin<PluginOptions>(async (server) => {",
" server.get('/plugin-generic-users', listPluginGenericUsers);",
"});",
"export const importEqualsRoutes = cjsPlugin(async (server) => {",
" server.get('/plugin-import-equals-users', listPluginImportEqualsUsers);",
"});",
"const defaultPlugin = require('fastify-plugin').default;",
"export const defaultRequireRoutes = defaultPlugin(async (app) => {",
" app.get('/plugin-default-require-users', listPluginDefaultRequireUsers);",
"});",
"export const typedArrowRoutes = async (server: FastifyInstance): Promise<void> => {",
" server.get('/plugin-typed-arrow-users', listPluginTypedArrowUsers);",
"};",
"const server = createHttpServer();",
"server.get('/not-plugin-server', ignoredServer);",
'export async function inlineRoutes(inlineApp: import("fastify").FastifyInstance) {',
' inlineApp.get("/plugin-inline-users", listPluginInlineUsers);',
"}",
'export const inlineArrowRoutes = async (inlineServer: import("fastify").FastifyInstance): Promise<void> => {',
' inlineServer.get("/plugin-inline-arrow-users", listPluginInlineArrowUsers);',
"};",
"function listPluginUsers() {}",
"function listPluginAppUsers() {}",
"function listPluginServerUsers() {}",
"function listPluginArrowUsers() {}",
"function listPluginAliasedUsers() {}",
"function listPluginGenericUsers() {}",
"function listPluginImportEqualsUsers() {}",
"function listPluginDefaultRequireUsers() {}",
"function listPluginTypedArrowUsers() {}",
"function listPluginInlineUsers() {}",
"function listPluginInlineArrowUsers() {}",
"function createHttpServer() { return { get() {} }; }",
"function ignoredApp() {}",
"function ignoredServer() {}",
"",
].join("\n"),
);
await writeFixture(
root,
"src/fastify-multiline-import.ts",
[
"import {",
" FastifyInstance,",
"} from 'fastify';",
"",
"export async function multilineRoutes(app: FastifyInstance) {",
" app.get('/plugin-multiline-users', listPluginMultilineUsers);",
"}",
"function listPluginMultilineUsers() {}",
"",
].join("\n"),
);
await writeFixture(
root,
"src/not-fastify-plugin.ts",
[
'import { FastifyInstance } from "./types"',
'import Fastify from "fastify"',
"export async function genericAppRoutes(app) {",
' app.get("/not-plugin-app", ignored);',
"}",
"export async function shadowInstanceRoutes(instance: FastifyInstance) {",
' instance.get("/shadow-fastify-instance", ignored);',
"}",
"function ignored() {}",
"",
].join("\n"),
);
Expand Down Expand Up @@ -2089,6 +2172,17 @@ describe("mapFeatures", () => {
"Fastify route GET /route-status",
"Fastify route POST /webhook/github",
"Fastify route GET /plugin-users",
"Fastify route GET /plugin-app-users",
"Fastify route GET /plugin-server-users",
"Fastify route GET /plugin-arrow-users",
"Fastify route GET /plugin-aliased-users",
"Fastify route GET /plugin-generic-users",
"Fastify route GET /plugin-import-equals-users",
"Fastify route GET /plugin-default-require-users",
"Fastify route GET /plugin-typed-arrow-users",
"Fastify route GET /plugin-inline-users",
"Fastify route GET /plugin-inline-arrow-users",
"Fastify route GET /plugin-multiline-users",
"Hono route GET /api/items",
"Hono route DELETE /sessions/:id",
]),
Expand All @@ -2111,6 +2205,10 @@ describe("mapFeatures", () => {
expect(titles).not.toContain("Express route GET /assigned-not-router");
expect(titles).not.toContain("Express route GET /dynamic/");
expect(titles).not.toContain("Fastify route GET /dynamic/");
expect(titles).not.toContain("Fastify route GET /not-plugin-app");
expect(titles).not.toContain("Fastify route GET /not-plugin-app-typed");
expect(titles).not.toContain("Fastify route GET /not-plugin-server");
expect(titles).not.toContain("Fastify route GET /shadow-fastify-instance");
expect(titles).not.toContain("Fastify route GET /concat-");
expect(titles).not.toContain("Express route DELETE /reports");
expect(admin?.source).toBe("express-route");
Expand Down
Loading