Merged
Conversation
fcoury-oai
approved these changes
Apr 6, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested the performance difference between main and this branch.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16244
This was a performance regression introduced when we moved the TUI on top of the app server API.
Problem:
/mcprebuilt a full MCP inventory throughmcpServerStatus/list, including resources and resource templates that made the TUI wait on slow inventory probes.Solution: add a lightweight
detailmode tomcpServerStatus/list, have/mcprequest tools-and-auth only, and cover the fast path with app-server and TUI tests.Testing: Confirmed slow (multi-second) response prior to change and immediate response after change.
I considered two options:
mcpServerStatus/listAPI to accept an optional "details" parameter so callers can request only a subset of the information.mcpServer/listAPI that returns only the servers, tools, and auth but omits the resources.I chose option 1, but option 2 is also a reasonable approach.