Skip to content

build: restore lzma-sys Bazel wiring for devbox codex run#16744

Open
starr-openai wants to merge 18 commits intomainfrom
starr/restore-bazel-16634-devbox-clean
Open

build: restore lzma-sys Bazel wiring for devbox codex run#16744
starr-openai wants to merge 18 commits intomainfrom
starr/restore-bazel-16634-devbox-clean

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

Summary

  • restore the #16634 lzma-sys / xz Bazel wiring that was reverted from main
  • re-enable direct Bazel linkage to @xz//:lzma with the lzma-sys build script disabled
  • restore the matching MODULE.bazel.lock entries

Why

origin/main currently builds //codex-rs/cli:cli on a devbox, but bazel run //codex-rs/cli:codex -- --version fails at link time on the same remote path. Restoring #16634 fixes that repro.

Validation

  • on origin/main: bazel build --bes_backend= --bes_results_url= //codex-rs/cli:cli passed
  • on origin/main: bazel run --bes_backend= --bes_results_url= //codex-rs/cli:codex -- --version failed on dev
  • after this patch on the same dev mirror: bazel run --bes_backend= --bes_results_url= //codex-rs/cli:codex -- --version passed and printed codex 0.0.0

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 029da41426

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

starr-openai added a commit that referenced this pull request Apr 4, 2026
starr-openai and others added 8 commits April 3, 2026 21:42
This seems to be required to fix bazel builds on an applied devbox

## Summary
- add the Bazel `xz` module
- wire `lzma-sys` directly to `@xz//:lzma` and disable its build script
- refresh `MODULE.bazel.lock`

## Validation
- `just bazel-lock-update`
- `just bazel-lock-check`
- `bazel run //codex-rs/cli:codex --run_under="cd $PWD &&" -- --version`
- `just bazel-codex --version`

Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/restore-bazel-16634-devbox-clean branch from 79d6226 to 4bebc8a Compare April 4, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants