build: restore lzma-sys Bazel wiring for devbox codex run#16744
Open
starr-openai wants to merge 18 commits intomainfrom
Open
build: restore lzma-sys Bazel wiring for devbox codex run#16744starr-openai wants to merge 18 commits intomainfrom
starr-openai wants to merge 18 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 029da41426
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
starr-openai
added a commit
that referenced
this pull request
Apr 4, 2026
This seems to be required to fix bazel builds on an applied devbox ## Summary - add the Bazel `xz` module - wire `lzma-sys` directly to `@xz//:lzma` and disable its build script - refresh `MODULE.bazel.lock` ## Validation - `just bazel-lock-update` - `just bazel-lock-check` - `bazel run //codex-rs/cli:codex --run_under="cd $PWD &&" -- --version` - `just bazel-codex --version` Co-authored-by: Codex <noreply@openai.com>
79d6226 to
4bebc8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#16634lzma-sys/xzBazel wiring that was reverted frommain@xz//:lzmawith thelzma-sysbuild script disabledMODULE.bazel.lockentriesWhy
origin/maincurrently builds//codex-rs/cli:clion a devbox, butbazel run //codex-rs/cli:codex -- --versionfails at link time on the same remote path. Restoring#16634fixes that repro.Validation
origin/main:bazel build --bes_backend= --bes_results_url= //codex-rs/cli:clipassedorigin/main:bazel run --bes_backend= --bes_results_url= //codex-rs/cli:codex -- --versionfailed ondevdevmirror:bazel run --bes_backend= --bes_results_url= //codex-rs/cli:codex -- --versionpassed and printedcodex 0.0.0