[BUGFIX] Fixed EagerLoadingMixin early return error#898
Open
calumbell wants to merge 2 commits intoopen5e:stagingfrom
Open
[BUGFIX] Fixed EagerLoadingMixin early return error#898calumbell wants to merge 2 commits intoopen5e:stagingfrom
calumbell wants to merge 2 commits intoopen5e:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
EagerLoadingMixinwhere the follow conditional:Would never evaluate as True due to
requested_fieldsbeing an array and arrays being Truthy in Python. This was replaced with a call toany()(which outputs true if any of the elements of an array is not false/falsey)The way that the fields were filtered in this mixin was also refactored to fix some additoinal bugs that taking a look at this issue exposed: specifically fields being filtered by sub-string matches, which might mess with nested fields with the same name, ie. a Creatures
namematching to itsdocument__name.Related Issue
Closes #897
How was this tested
pytest(all tests passing)