Skip to content

Fix eachdist dependency version matching #5237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HasanTasdiq wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix eachdist dependency version matching #5237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3e3dcb
fix: tighten eachdist dependency version matching
HasanTasdiq May 20, 2026
1b430ec
chore: add changelog for eachdist dependency matching
HasanTasdiq May 20, 2026
f2901df
fix: simplify eachdist dependency match
HasanTasdiq May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5237.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent release tooling from matching dependency name prefixes.
4 changes: 2 additions & 2 deletions scripts/eachdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ def update_dependencies(targets, version, packages):
operators_pattern = "|".join(re.escape(op) for op in operators)

for pkg in packages:
search = rf"({basename(pkg)}[^,]*)({operators_pattern})(.*\.dev)"
search = rf"({basename(pkg)}\s+)({operators_pattern})(.*\.dev)"
replace = r"\1\2 " + version
update_files(
targets,
Expand All @@ -618,7 +618,7 @@ def update_patch_dependencies(targets, version, prev_version, packages):
operators_pattern = "|".join(re.escape(op) for op in operators)

for pkg in packages:
search = rf"({basename(pkg)}[^,]*?)(\s?({operators_pattern})\s?)(.*{prev_version})"
search = rf"({basename(pkg)}\s+)(\s?({operators_pattern})\s?)(.*{prev_version})"
replace = r"\g<1>\g<2>" + version
print(f"{search=}\t{replace=}\t{pkg=}")
update_files(
Expand Down