[BUILD] Avoid break caused by max() macro on windows#3863
Merged
marcalff merged 2 commits intoopen-telemetry:mainfrom Feb 13, 2026
Merged
[BUILD] Avoid break caused by max() macro on windows#3863marcalff merged 2 commits intoopen-telemetry:mainfrom
marcalff merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3863 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 225 225
Lines 7170 7170
=======================================
Hits 6452 6452
Misses 718 718 🚀 New features to boost your workflow:
|
ThomsonTan
approved these changes
Feb 12, 2026
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Feb 13, 2026
[BUILD] Avoid break caused by max() macro on windows (open-telemetry#3863)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3861
Changes
Please provide a brief description of the changes here.
max(), to avoid collisions withmaxmacros on windows.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes