feature: Add action to deploy previews on PR#106
Conversation
This will enable the function of preview deployments when a PR is open and removes them when the PR is closed. Should close #102 Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
|
|
Well it seems that we have a hard redirect from https://open-gitops.github.io to https://opengitops.dev/ which means that we have to figure out if it is possible to host previews like that. |
|
I wonder if we could have a subdomain for this? Like |
|
We should fix any hard redirects. For the most part links are relative, at least it seems that way based on local dev |
|
I believe this is fixed with #105 |
|
I will have a closer look into this in the next days. It still seems to be the case that the redirect is going against the regular |
|
I noticed this has been stalled waiting for reviews. Is this PR still relevant after #105 ? |
|
Hello, I just want to bring attention to the limits that the GitHub page has, we maybe don't hit this in the near term but it is something to consider https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits cc @scottrigby |
|
should we close this PR? @todaywasawesome @scottrigby ? |
|
This is a nice to have, it should not be a blocker. PR reviewers can still build the website on PR branches locally and preview that way as part of the preview process. |
I honestly don't know, but I'd be willing to give it a shot and fix any problems that arise. @niklasmtj WDYT, would you want to update this PR at all or just merge and see if we need to revert if anything goes wrong? |
7 participants
This will enable the function of preview deployments when a PR is open and removes them when the PR is closed.
Should close #102