Conversation
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @dferber90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Vercel Flags as a new feature flag provider within the ecosystem, enhancing the available options for users. To prevent naming conflicts and improve clarity, existing SDKs previously named 'Vercel Flags' have been rebranded to 'Flags', along with updated descriptions. This ensures a clear distinction between the new Vercel-specific provider and the more general, vendor-agnostic SDKs. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds Vercel Flags as a new provider, which is a great addition. The changes also clarify the naming of the existing 'Flags' SDK for Next.js and SvelteKit. My review includes a few suggestions to improve code maintainability by sorting lists and to enhance clarity by updating SDK descriptions to be consistent with the new naming.
|
This is great news @dferber90! |
lukas-reining
left a comment
There was a problem hiding this comment.
Thanks @dferber90 this is great!
From my side we can merge it as is, I would still be happy to get feedback from someone else if they agree.
@toddbaert @beeme1mr @thomaspoignant @askpt @jonathannorris
Signed-off-by: Dominik Ferber <dominik.ferber@gmail.com>
|
@lukas-reining appreciate the review, I fixed the DCO |
Vercel recently released Vercel Flags, a feature flag provider built into the Vercel platform (changelog). The official SDK also contains an OpenFeature adapter (docs). This pull request adds Vercel Flags to the list of available providers, and also renames the Flags SDK entries to clearly distinguish them.
This PR
vercel-no-fill.svg)Notes
https://vercel.com/changelog/vercel-flags-is-now-in-public-beta
How to test
visit /ecosystem?instant_search%5Bquery%5D=vercel