FLO-3 panic if topUpSource deposit leaves position liquidatable#242
Open
FLO-3 panic if topUpSource deposit leaves position liquidatable#242
Conversation
holyfuchs
changed the title
jordanschalm
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #212
Description
Fixes FLO-3. _rebalancePositionNoLock was depositing whatever it could pull from topUpSource without verifying the position was actually rescued. If the source was underfunded, the backup funds would end up in a still-liquidatable position and be seized.
After the deposit, we now assert health >= 1.0. If the position remains liquidatable the transaction panics and reverts, leaving the source funds untouched.