Skip to content

FLO-4 fix rebalancer to use positionID#203

Open
holyfuchs wants to merge 2 commits intomainfrom
holyfuchs/FLO-4-createPaidRebalancer
Open

FLO-4 fix rebalancer to use positionID#203
holyfuchs wants to merge 2 commits intomainfrom
holyfuchs/FLO-4-createPaidRebalancer

Conversation

@holyfuchs
Copy link
Member

@holyfuchs holyfuchs commented Mar 5, 2026

Closes: #213

Summary

Refactors the paid rebalancer to use position-based identifiers and documents the permissionless design.

Changes

  • Refactor: Use positionID (and id param labels) instead of uuid across the paid rebalancer and supervisor API.
  • One per position: storeRebalancer panics with "rebalancer already exists" if one is already stored for that position; covered by tests.
  • Docs: Docstrings updated for permissionless design and security.

Security & constraints

  • Permissionless: Anyone with a position rebalance cap can call createPaidRebalancer.
  • Spam: Mitigated by existing economic cost of positions (e.g. minimumBalance), not by this contract.

@holyfuchs holyfuchs requested a review from a team as a code owner March 5, 2026 13:47
Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you for also keeping documentation up to date 🙇

@holyfuchs holyfuchs changed the title fix rebalancer to use positionID FLO-4 fix rebalancer to use positionID Mar 6, 2026
Co-authored-by: Jordan Schalm <jordan.schalm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FLO-4: createPaidRebalancer Is Permissionless Where Anyone Can Drain Admin's Flow

2 participants