test: return invalid argument when rawData size is passed as 0 to tracer #351
Conversation
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
| LOG_DEBUG << "synchronize with completion of workload"; | ||
| lzt::synchronize(command_queue, std::numeric_limits<uint64_t>::max()); | ||
|
|
||
| size_t raw_data_size = 0; |
There was a problem hiding this comment.
please confirm, but I suspect this test does not need to run any workload. Since it is just an API param check.
There was a problem hiding this comment.
Yes you are right. Removed running the workload.
There was a problem hiding this comment.
It seems this test does not make sense any more since you cannot know how much size is available.
Instead seems there should be a test that sets a small buffer and confirms can read multiple times, concatenate data and call calculate and data is valid. This will be the most used case.
There was a problem hiding this comment.
I have modified this test to read the data completely using the small buffer. Let me know if this test is okay.
Cannot use the new decode and calculate here since it is still driver experimental. Will add that test scenario in embargo.
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
Related-To: VLCLJ-2678 Signed-off-by: Shreyas Kunder <shreyas.kunder@intel.com>
matcabral
left a comment
matcabral
left a comment
There was a problem hiding this comment.
changes look good. Please paste output of passing tests.
3 participants
Related-To: VLCLJ-2678