Skip to content

feat: migrate reth dependencies from v1.10.2 to v1.11.0 with optimism…#151

Draft
louisliu2048 wants to merge 7 commits intomainfrom
xiong/migration
Draft

feat: migrate reth dependencies from v1.10.2 to v1.11.0 with optimism…#151
louisliu2048 wants to merge 7 commits intomainfrom
xiong/migration

Conversation

@louisliu2048
Copy link
Collaborator

… submodule

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Other (please describe):

Code Guidelines

Before submitting your PR, please review the relevant code guidelines in the docs/ folder:

Specific Guidelines by Component:

Checklist

  • I have reviewed the relevant code guidelines in the docs/ folder
  • My code follows the coding standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Testing

Additional Notes

@louisliu2048 louisliu2048 marked this pull request as ready for review February 26, 2026 08:03
Copy link
Contributor

@Vui-Chee Vui-Chee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • bin/tools/import.rs: defaulting ImportConfig.fail_on_invalid_block to false changes import strictness; is this intentional for all environments or should it be configurable via CLI?
  • Cargo.toml: please confirm all op-alloy crates pulled transitively by reth v1.11.0 are redirected to the local optimism workspace to avoid duplicate type definitions.

Copy link
Contributor

@Vui-Chee Vui-Chee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both notes are not needed:

  • fail_on_invalid_block: required field added to match upstream ImportConfig API (not a behavior choice)
  • op-alloy patching: comprehensive [patch.crates-io] section already covers all relevant crates

LGTM!

@louisliu2048 louisliu2048 marked this pull request as draft February 26, 2026 08:30
fix: copy dependencies in dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants