Replace aliases in Aliases_of_canonical_element.t with 3 fields#383
Open
lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
Open
Replace aliases in Aliases_of_canonical_element.t with 3 fields#383lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
aliases in Aliases_of_canonical_element.t with 3 fields#383lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
Conversation
`Aliases_of_canonical_element.t` carries around a map from `Name_mode.t` to `Simple.Set.t` so that it can compute the earliest element in each name mode. This is less efficient than simply having a field for each name mode. Furthermore, we don't need the sets if we just track the earliest for each name mode (along with its binding time).
|
@poechsel is going to review this! |
poechsel
reviewed
Mar 31, 2021
| update_all_earliest t ~f:(fun earliest -> | ||
| match earliest with | ||
| | Earliest { name; _ } when Simple.is_var name -> No_alias | ||
| | _ -> earliest) |
lthls
reviewed
Apr 1, 2021
| { t with all; } | ||
|
|
||
| let move_variables_to_mode_in_types t = | ||
| update_all_earliest t ~f:(fun earliest -> |
There was a problem hiding this comment.
This looks wrong. I would expect earliest and earliest_ge_in_types to be left unchanged by this function.
There was a problem hiding this comment.
(Although #393 gets rid of this function completely, so maybe it isn't that important anyway)
This was referenced Apr 1, 2021
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases_of_canonical_element.tcarries around a map fromName_mode.tto
Simple.Set.tso that it can compute the earliest element in eachname mode. This is less efficient than simply having a field for each
name mode. Furthermore, we don't need the sets if we just track the
earliest for each name mode (along with its binding time).