Type_descr.join: preserve aliases on join with Bottom#327
Merged
chambart merged 3 commits intoocaml-flambda:flambda2.0-stablefrom Apr 15, 2021
Merged
Type_descr.join: preserve aliases on join with Bottom#327chambart merged 3 commits intoocaml-flambda:flambda2.0-stablefrom
chambart merged 3 commits intoocaml-flambda:flambda2.0-stablefrom
Conversation
Author
|
I've rebased this PR on top of #329, as without it we generate wrong code, and added an example. |
|
Good when 329 is in |
|
I'd like the test to be added to the testsuite : if this allocates, the join fails. This should probably wait for the new unboxing for this to be valid. And the test needs to be changed a bit so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a bit surprised that
Type_descr.joindoesn't seem to care whether the resulting type is valid in the target env, but at least when coming fromTyping_env_level.jointhe target env always contains all the names from both branches, so this should be safe.