Sort mutually-recursive constants by linkage name, not id#315
Open
lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
Open
Sort mutually-recursive constants by linkage name, not id#315lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
lukemaurer wants to merge 1 commit intoflambda2.0-stablefrom
Conversation
Since flexpect does a straightforward one-to-one comparison, the order in which the bindings occur is important even within a recursive group, and we can't have that order depend on something fragile like what integer ids things happen to be assigned. Specifically, we get a spurious test failure from a generated .flt test if the ids in the original run happen to be different from the ids in the test run. If we sort them by linkage name instead, the ordering should be consistent.
|
Two comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since flexpect does a straightforward one-to-one comparison, the order
in which the bindings occur is important even within a recursive group,
and we can't have that order depend on something fragile like what
integer ids things happen to be assigned. Specifically, we get a
spurious test failure from a generated .flt test if the ids in the
original run happen to be different from the ids in the test run.
If we sort them by linkage name instead, the ordering should be
consistent.