Conversation
Signed-off-by: Si Dao <dao@singoc.com>
|
Hi @fb87, Is this problem specific to NixOS? there was also an attempt in #179 which frankly I didn't like the look of but this looks more robust than that. Generally I really want to avoid having logic for specific OSes, I really didn't but should have realised what a nasty rabbit hole I was getting into handling any of the path stuff for users and should frankly have just said something like make sure the binaries are in the $PATH for vim or use the full path. Anyway ship has sailed now. I think rather than just adding another path to search I'd rather first see if the full path passed to the config can't work for Nix or anyone else who's path is more custom than what is already handled and if not see if theres some way to just expose something that the user can take control of and do with what they may rather than continue down the path of more and more edge cases for different OSes. |
|
The binaries ( IMO, we can introduce the other options which allows user to specify where the |
I think this would be good since hopefully the combination will close out all future requests for custom locations since users will now just be able to set it themselves |
Some system like NixOS, the dart is nested within
flutter/binwhich leads to the error where dart will not be found as current implementation. This patch adds theflutter/bin/cache/dart-sdk/binto the search paths along withflutter/bin. This is short term solution, for long term, IMO we can search for the executable dart withinflutter/bin.