feat(modules): add nuxt.care health score badges #924
Conversation
📝 WalkthroughWalkthroughAdds Nuxt module health/score integration to the devtools client. Introduces a new composable Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <template> | ||
| <ModuleItemBase :mod="mod" :info="staticInfo"> | ||
| <template #badge> | ||
| <ModuleScoreBadge class="ml-1" :npm="data.npm" /> |
There was a problem hiding this comment.
About the UI styling, I wonder if this would be better as an item in the table instead of the badge? As I consider the "score" is only one of the aspects of the modules, and does not always reflects if users needs to do any action on that.
There was a problem hiding this comment.
A short table item inside the module item? Sure. make sense - I will try something
| try { | ||
| const params = new URLSearchParams([ | ||
| ['slim', 'true'], | ||
| ...missing.map(name => ['package', name]), |
There was a problem hiding this comment.
Might be a bit out-of-scope of the current PR, but I wonder if nuxt.care should also count for module versions? In many cases, the users might have an out-dated, no-longer-maintained version installed, where the "score" should be relatively low and ask users to upgrade.
There was a problem hiding this comment.
That's a nice idea! But this time nuxt care doesn't save a history. So I always see the current state. To say: new version available - yes, but nuxt care will have no different score between different versions with the current state.
Anthony, I love this idea... and now I'm sure I can check older versions! I need some days, but I will implement this great feature!
| const installedModules = useInstalledModules() | ||
|
|
||
| const npmNames = computed(() => | ||
| installedModules.value |
There was a problem hiding this comment.
Ohter than the fixed "installedModules", we also reuse the UI for modules to install, I wonder if we also need to show the scores (or actually more interesting/useful?) when users are installing new modules.
There was a problem hiding this comment.
Totally forgot about that. Yes I will work on it!
|
Hi! Hover on Health: If there is a new vesion with a better score you'll see the health icon which shows: Here you can start the regular mocule update process. Install a new module shows now also some infos: I'm open for feedback! Maybe I should ping you too @antfu, so you know. 🙏 |
2 participants
❓ Type of change
📚 Description
Adds health score badges from nuxt.care to installed modules, giving developers quick visibility into module maintenance status.
Screenshots
💚 Built in collaboration with nuxt.care