Use Microsoft.Windows.SDK.BuildTools package to get signtool binary #1558
Open
gpailler wants to merge 1 commit intonuke-build:developfrom
Open
Use Microsoft.Windows.SDK.BuildTools package to get signtool binary #1558gpailler wants to merge 1 commit intonuke-build:developfrom
gpailler wants to merge 1 commit intonuke-build:developfrom
Conversation
… of predefined Windows SDK paths Fixes nuke-build#1186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the SignTool integration to improve how the tool is located.
It relies on the official NuGet package Microsoft.Windows.SDK.BuildTools and not on an installed Windows SDK anymore.
This is a breaking change and projects using SingTool must run
nuke :add-package Microsoft.Windows.SDK.BuildToolsFixes #1186
I confirm that the pull-request: