Skip to content

Remove sync name prefix configuration from arcane-deploy#12

Merged
nsheaps merged 1 commit intomainfrom
claude/arcane-deploy-github-action-XMCBB
Mar 19, 2026
Merged

Remove sync name prefix configuration from arcane-deploy#12
nsheaps merged 1 commit intomainfrom
claude/arcane-deploy-github-action-XMCBB

Conversation

@nsheaps
Copy link
Owner

@nsheaps nsheaps commented Mar 19, 2026

Summary

This PR removes the sync-name-prefix input parameter and related logic from the arcane-deploy GitHub Action, simplifying how sync names are derived from compose file paths.

Key Changes

  • Removed sync-name-prefix input parameter from action.yml
  • Removed SYNC_NAME_PREFIX variable initialization from action.sh
  • Simplified sync_name_from_path() function to generate sync names without prefix logic:
    • Root-level compose files now map to "root" instead of the repository name
    • Nested compose files now map to their directory name only (e.g., "myapp" instead of "prefix-myapp")
    • Removed conditional logic that prevented duplicate prefixes
  • Removed the INPUT_SYNC_NAME_PREFIX environment variable from the action runner configuration

Implementation Details

The sync naming is now deterministic and based solely on the file path structure, eliminating the need for external configuration. This reduces complexity and makes sync names more predictable across different repository setups.

https://claude.ai/code/session_01KxSbM7uQL4SrYBjKpGL8yd

The prefix added no functional value since syncs are already scoped
by environment (host) in Arcane. Root compose files now get the name
"root" instead of the repo name.
@nsheaps nsheaps enabled auto-merge (squash) March 19, 2026 18:07
@nsheaps nsheaps merged commit 4abbb29 into main Mar 19, 2026
2 checks passed
@nsheaps nsheaps deleted the claude/arcane-deploy-github-action-XMCBB branch March 19, 2026 18:08
# "stacks/myapp/compose.yml" -> "${prefix}-myapp"
# "compose.yml" (root) -> "${prefix}"
# "stacks/myapp/compose.yml" -> "myapp"
# "compose.yml" (root) -> "root"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will never be possible. Everything will have a name.

What other complications are hiding behind the accordion here? Why isn't this as simple as possible?

Copy link
Owner Author

@nsheaps nsheaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified — removed the dead root fallback. sync_name_from_path is now a single expression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants