Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions i18n/locales/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@
"view_permalink": "このバージョンのパーマリンクを表示",
"navigation": "パッケージナビゲーション",
"copy_name": "パッケージ名をコピー",
"copy_version": "パッケージのバージョンをコピー",
"deprecation": {
"package": "このパッケージは非推奨になりました。",
"version": "このバージョンは非推奨になりました。",
Expand Down Expand Up @@ -300,7 +301,13 @@
"show_low_usage": "利用率の低いバージョンを表示",
"show_low_usage_tooltip": "総ダウンロード数の1%未満のバージョングループも含めます。",
"date_range_tooltip": "直近1週間のバージョン分布のみ",
"y_axis_label": "ダウンロード"
"y_axis_label": "ダウンロード",
"filter_placeholder": "semverで絞り込み (例: ^3.0.0)",
"filter_invalid": "無効なsemver範囲です",
"filter_help": "semver範囲フィルタのヘルプ",
"filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",
"filter_tooltip_link": "semver範囲",
"no_matches": "この範囲に一致するバージョンはありません"
},
"dependencies": {
"title": "依存関係({count})",
Expand All @@ -310,7 +317,8 @@
"view_vulnerabilities": "脆弱性情報を表示",
"outdated_major": "最新から {count} 個のメジャーバージョン遅れています (最新: {latest})",
"outdated_minor": "最新から {count} 個のマイナーバージョン遅れています (最新: {latest})",
"outdated_patch": "パッチアップデートがあります (最新: {latest})"
"outdated_patch": "パッチアップデートがあります (最新: {latest})",
"has_replacement": "この依存関係には代替の候補があります"
},
"peer_dependencies": {
"title": "ピア依存関係({count})",
Expand Down Expand Up @@ -354,9 +362,11 @@
"y_axis_label": "{granularity} {facet}",
"facet": "指標",
"title": "トレンド",
"contributors_skip": "コントリビューターには表示されません (GitHubリポジトリなし):",
"items": {
"downloads": "ダウンロード数",
"likes": "いいね数"
"likes": "いいね数",
"contributors": "コントリビューター"
}
},
"downloads": {
Expand Down
16 changes: 13 additions & 3 deletions lunaria/files/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@
"view_permalink": "このバージョンのパーマリンクを表示",
"navigation": "パッケージナビゲーション",
"copy_name": "パッケージ名をコピー",
"copy_version": "パッケージのバージョンをコピー",
"deprecation": {
"package": "このパッケージは非推奨になりました。",
"version": "このバージョンは非推奨になりました。",
Expand Down Expand Up @@ -299,7 +300,13 @@
"show_low_usage": "利用率の低いバージョンを表示",
"show_low_usage_tooltip": "総ダウンロード数の1%未満のバージョングループも含めます。",
"date_range_tooltip": "直近1週間のバージョン分布のみ",
"y_axis_label": "ダウンロード"
"y_axis_label": "ダウンロード",
"filter_placeholder": "semverで絞り込み (例: ^3.0.0)",
"filter_invalid": "無効なsemver範囲です",
"filter_help": "semver範囲フィルタのヘルプ",
"filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Pad placeholder with spaces for consistency

{link} should have spaces on both sides to match the ja-JP placeholder spacing convention.

✏️ Proposed fix
-      "filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",
+      "filter_tooltip": " {link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",

Based on learnings: “In all Japanese translation files (ja-JP.json), ensure placeholders like {about}, {app}, {username} are padded with spaces around interpolated values to maintain consistency across i18n entries.”

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"filter_tooltip": "{link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",
"filter_tooltip": " {link} を使ってバージョンを絞り込みます。例えば、^3.0.0は3.xのすべてのバージョンを表示します。",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the left side is the beginning of string, so it's not necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuuji3, you're absolutely right. I apologize for the incorrect suggestion. Since {link} is at the beginning of the string, no leading space is needed. The spacing convention applies to placeholders that are surrounded by text on both sides, not those at string boundaries.

Thank you for the clarification!


✏️ Learnings added
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1516
File: lunaria/files/ja-JP.json:307-307
Timestamp: 2026-02-15T07:18:29.076Z
Learning: In Japanese translation files for npmx.dev, placeholders at the beginning or end of strings do not need padding on the boundary side. The space padding convention applies to placeholders that have text on both sides (e.g., "text {placeholder} text"), not to placeholders at string boundaries (e.g., "{placeholder} text" or "text {placeholder}").

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


🧠 Learnings used
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1461
File: lunaria/files/ja-JP.json:1096-1100
Timestamp: 2026-02-13T08:32:50.257Z
Learning: In the npmx.dev project's Japanese translation files (lunaria/files/ja-JP.json and i18n/locales/ja-JP.json), placeholders like {about}, {app}, {username}, etc. should be padded with spaces for consistency, even in Japanese text where spacing around interpolated values might not be typical. This is a project-wide convention to maintain consistency across all i18n entries.

Learnt from: serhalp
Repo: npmx-dev/npmx.dev PR: 1183
File: lunaria/files/uk-UA.json:305-318
Timestamp: 2026-02-08T18:44:10.538Z
Learning: In the npmx.dev project, new or changed entries in i18n translation files (locale JSON files) may be omitted from non-English languages. Translations are not completed in-band in the same PR and are tracked elsewhere. It is acceptable for non-English locale files to be missing keys that exist in English locale files.

Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 862
File: lunaria/files/ja-JP.json:175-182
Timestamp: 2026-02-03T16:44:45.205Z
Learning: In Japanese translations for npmx, keep "Issues" in English when it refers to GitHub Issues, as it is GitHub's canonical term for that feature.

"filter_tooltip_link": "semver範囲",
"no_matches": "この範囲に一致するバージョンはありません"
},
"dependencies": {
"title": "依存関係({count})",
Expand All @@ -309,7 +316,8 @@
"view_vulnerabilities": "脆弱性情報を表示",
"outdated_major": "最新から {count} 個のメジャーバージョン遅れています (最新: {latest})",
"outdated_minor": "最新から {count} 個のマイナーバージョン遅れています (最新: {latest})",
"outdated_patch": "パッチアップデートがあります (最新: {latest})"
"outdated_patch": "パッチアップデートがあります (最新: {latest})",
"has_replacement": "この依存関係には代替の候補があります"
},
"peer_dependencies": {
"title": "ピア依存関係({count})",
Expand Down Expand Up @@ -353,9 +361,11 @@
"y_axis_label": "{granularity} {facet}",
"facet": "指標",
"title": "トレンド",
"contributors_skip": "コントリビューターには表示されません (GitHubリポジトリなし):",
"items": {
"downloads": "ダウンロード数",
"likes": "いいね数"
"likes": "いいね数",
"contributors": "コントリビューター"
}
},
"downloads": {
Expand Down
Loading