feat: add server-synced user preferences infrastructure (#484) #1189
+996
−451
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { createDefu } from 'defu' | ||
| import { createLocalStorageProvider } from '~/utils/storage' | ||
|
|
||
| const defu = createDefu((object, key, value) => { | ||
| if (Array.isArray(object[key]) && Array.isArray(value)) { | ||
| object[key] = value | ||
| return true | ||
| } | ||
| }) | ||
|
|
||
| export function useLocalStorageHashProvider<T extends object>(key: string, defaultValue: T) { | ||
| const provider = createLocalStorageProvider<T>(key) | ||
| const data = ref<T>(defaultValue) | ||
|
|
||
| onMounted(() => { | ||
| const stored = provider.get() | ||
| if (stored) { | ||
| data.value = defu(stored, defaultValue) | ||
| } | ||
| }) | ||
|
|
||
| function save() { | ||
| provider.set(data.value) | ||
| } | ||
|
|
||
| function reset() { | ||
| data.value = { ...defaultValue } | ||
| provider.remove() | ||
| } | ||
|
|
||
| function update<K extends keyof T>(key: K, value: T[K]) { | ||
| data.value[key] = value | ||
| save() | ||
|
Comment on lines
+11
to
+33
Contributor
There was a problem hiding this comment. Prevent shared default mutations in the storage provider
🛠️ Suggested fix export function useLocalStorageHashProvider<T extends object>(key: string, defaultValue: T) {
const provider = createLocalStorageProvider<T>(key)
- const data = ref<T>(defaultValue)
+ const data = ref<T>(structuredClone(defaultValue))
onMounted(() => {
const stored = provider.get()
if (stored) {
- data.value = defu(stored, defaultValue)
+ data.value = defu(stored, structuredClone(defaultValue))
}
})
function reset() {
- data.value = { ...defaultValue }
+ data.value = structuredClone(defaultValue)
provider.remove()
} |
||
| } | ||
|
|
||
| return { | ||
| data, | ||
| save, | ||
| reset, | ||
| update, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard JSON.parse in onPrehydrate to prevent crashes.
If
localStorage.getItem('npmx-user-preferences')contains malformed JSON, the parse will throw and break the prehydrate logic. Wrap in try/catch for resilience.🛠️ Suggested fix
onPrehydrate(el => { - const preferences = JSON.parse(localStorage.getItem('npmx-user-preferences') || '{}') - const id = preferences.accentColorId + let id = null + try { + const preferences = JSON.parse(localStorage.getItem('npmx-user-preferences') || '{}') + id = preferences?.accentColorId + } catch { + // Ignore malformed JSON + } if (id) {As per coding guidelines, "Use error handling patterns consistently".
📝 Committable suggestion