-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: adds asdf installation instructions to downloads page #8533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6a4a4ab
6849c14
df85d32
cee69a2
b0f2278
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # asdf has specific installation instructions for each operating system. | ||
| # Please refer to the official documentation at https://asdf-vm.com/guide/getting-started.html. | ||
|
|
||
| # Install the Node.js plugin | ||
| asdf plugin add nodejs https://github.com/asdf-vm/asdf-nodejs.git | ||
|
|
||
| # Download and install Node.js ${props.release.version} | ||
| asdf install nodejs ${props.release.version} | ||
|
|
||
| # Set global Node.js version to ${props.release.version} | ||
| asdf set -u nodejs ${props.release.version} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,9 +78,15 @@ export const parseCompat = < | |
| */ | ||
| const createIcon = ( | ||
| IconModule: Record<string, ElementType>, | ||
| iconName: string | ||
| iconName?: string | ||
| ) => { | ||
| if (!iconName) { | ||
| return undefined; | ||
| } | ||
| const IconComponent = IconModule[iconName]; | ||
| if (!IconComponent) { | ||
| return undefined; | ||
| } | ||
|
Comment on lines
+83
to
+89
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we do this on the caller, ie
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JacobNWolf can you please revert this? This PR should only add asdf as a method and not do any other sort of change, thank you! |
||
| return <IconComponent width={16} height={16} />; | ||
| }; | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.