Skip to content

tools: add a check for clean git tree after tests #62661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

tools: add a check for clean git tree after tests #62661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ jobs:
run: make -C node build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --v8-enable-temporal-support"
- name: Test
run: make -C node test-ci -j1 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
- name: Ensure running tests did not cause any change in the tree
run: cd node && git diff --name-only --exit-code
Comment on lines +83 to +84
Copy link
Copy Markdown
Member

@avivkeller avivkeller Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Ensure running tests did not cause any change in the tree
run: cd node && git diff --name-only --exit-code
- name: Ensure running tests did not cause any change in the tree
working-directory: node
run: git diff --name-only --exit-code

nitpick, has no real improvement, but a little bit cleaner

- name: Re-run test in a folder whose name contains unusual chars
run: |
mv node "$DIR"
Expand Down
Loading