fs: fix always return promise from fs.openAsBlob#62655
Draft
mattskel wants to merge 1 commit intonodejs:mainfrom
Draft
fs: fix always return promise from fs.openAsBlob#62655mattskel wants to merge 1 commit intonodejs:mainfrom
fs.openAsBlob#62655mattskel wants to merge 1 commit intonodejs:mainfrom
Conversation
Wrap path validation and blob creation in try/catch. Any synchronous errors become Promise rejections. Ensures the function always returns a Promise. Fixes: nodejs#62418
nodejs-github-bot
added
fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Ensure
fs.openAsBlobalways returns a Promise by converting synchronous validation/creation errors into Promise rejections so error handling is consistent.Motivation: The issue reported that openAsBlob can throw synchronously (for invalid paths), which bypasses
await/.catch. This aligns behaviour with the Promise-based API contract.Changes: Wrap getValidatedPath and createBlobFromFilePath in
try/catchand return Promise.reject on failure.Fixes: #62418