crypto: always return certificate serial numbers as uppercase

[addaleax]

This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values.

Refs: #61459 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71271/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (a8479a2) to head (c2c8497).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61752      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.02%     
==========================================
  Files         675      675              
  Lines      204601   204601              
  Branches    39317    39314       -3     
==========================================
- Hits       183625   183601      -24     
- Misses      13240    13284      +44     
+ Partials     7736     7716      -20     

Files with missing lines	Coverage Δ
src/crypto/crypto_x509.cc	73.08% <100.00%> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ranjuhasankhan]

Nice

[ranjuhasankhan]

Nice

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71273/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71276/

[tniessen]

I believe that the difference in behavior is due to BN_bn2hex, which ncrypto wraps in BignumPointer::toHex(). Maybe we should just wrap that call when Node.js is linked against BoringSSL?

[addaleax]

@tniessen Yeah, I considered that too, but a) I didn't want to do this while the discussion in #61613 is alive and well and b) this is the only site where we expose this to users, and it's not obvious to me that we always care whether the call returns uppercase or lowercase hex?

But I'm not feeling particularly strongly about this, and I'm happy to make that change there as well (if you feel confident about the repo in which that should happen 😅 )

[tniessen]

That works for me @addaleax :)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71287/