-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
doc: fix node-config-schema #61596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
doc: fix node-config-schema #61596
Conversation
|
Review requested:
|
|
The schema is automaticly generated so this change will be overwritten. |
|
@marco-ippolito The generator is wrong and has to be fixed then. |
|
@marco-ippolito updated. |
|
This is where the schema is generated: |
9aba333 to
40bfdac
Compare
|
@marco-ippolito 🤦🏻 i forgot to add the last There is now only unrelated difference between what diff --git a/doc/node-config-schema.json b/doc/node-config-schema.json
index ad1c4440108..5811cf8892d 100644
--- a/doc/node-config-schema.json
+++ b/doc/node-config-schema.json
@@ -164,9 +164,6 @@
"experimental-print-required-tla": {
"type": "boolean"
},
- "experimental-quic": {
- "type": "boolean"
- },
"experimental-repl-await": {
"type": "boolean"
},
@@ -351,6 +348,9 @@
}
]
},
+ "require-module": {
+ "type": "boolean"
+ },
"secure-heap": {
"type": "number"
}, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61596 +/- ##
==========================================
- Coverage 89.77% 89.77% -0.01%
==========================================
Files 672 673 +1
Lines 203755 203897 +142
Branches 39167 39189 +22
==========================================
+ Hits 182922 183044 +122
- Misses 13164 13183 +19
- Partials 7669 7670 +1
🚀 New features to boost your workflow:
|
Fixes #61595
minItemswas used incorrectly"required": [],was added to explicitly document that there are no required properties (which allows running inrequireValidationmode which also ensures that no props are non-typed)It now passes in:
require('@exodus/schemasafe').validator(require('../../doc/node-config-schema.json')require('@exodus/schemasafe').validator(require('../../doc/node-config-schema.json', { requireValidation: true })Strings are still not validated