-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
url: update ada to v3.4.2 and support unicode 17 #61593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anonrig
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
anonrig:yagiz/update-ada-v-3-4-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,847
−1,840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
bb26dde to
fe29dec
Compare
Contributor
|
FWIW it doesn't require a manual PR, it's certainly fine to push a fixup commit to the bot PR, but a manual PR also works |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61593 +/- ##
==========================================
- Coverage 89.79% 89.77% -0.03%
==========================================
Files 673 673
Lines 203852 203852
Branches 39181 39182 +1
==========================================
- Hits 183044 182998 -46
- Misses 13143 13189 +46
Partials 7665 7665 🚀 New features to boost your workflow:
|
aduh95
approved these changes
Jan 30, 2026
gurgunday
approved these changes
Jan 30, 2026
Collaborator
RafaelGSS
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required manual pull-request since remaining failed web-platform tests are now passing. cc @nodejs/url