Skip to content

util: add hex colors support in styleText#61556

Open
araujogui wants to merge 8 commits intonodejs:mainfrom
araujogui:util/colorize-hex
Open

util: add hex colors support in styleText#61556
araujogui wants to merge 8 commits intonodejs:mainfrom
araujogui:util/colorize-hex

Conversation

@araujogui
Copy link
Member

Fixes #61543

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (53ac826) to head (bb6b1b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61556   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         674      674           
  Lines      204808   204874   +66     
  Branches    39364    39373    +9     
=======================================
+ Hits       183812   183872   +60     
+ Misses      13280    13275    -5     
- Partials     7716     7727   +11     
Files with missing lines Coverage Δ
lib/util.js 98.24% <100.00%> (+0.20%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases for invalid values.

@araujogui araujogui requested a review from Renegade334 January 29, 2026 18:50
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

@gurgunday gurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2026
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 18, 2026
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 18, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have a green CI yet, would you mind including hex to styleText benchmarks? We are working to improve that, and it would be interesting to see if this decreases performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[util] Allow styleText to take in hex colors

8 participants

Comments