Skip to content

deps: update ada to 3.4.1 #61338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nodejs-github-bot wants to merge 1 commit into from
Closed

deps: update ada to 3.4.1 #61338

nodejs-github-bot wants to merge 1 commit into from
+1,843 −702

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 11, 2026

This is an automated update of ada to 3.4.1.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jan 11, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 11, 2026

Review requested:

  • @nodejs/security-wg
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 11, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 11, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 11, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70775/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 12, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70782/

@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 15, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70820/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 15, 2026

Commit Queue failed
- Loading data for nodejs/node/pull/61338
✔  Done loading data for nodejs/node/pull/61338
----------------------------------- PR info ------------------------------------
Title      deps: update ada to 3.4.1 (#61338)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-ada -> nodejs:main
Labels     author ready, needs-ci, dependencies
Commits    1
 - deps: update ada to 3.4.1
Committers 1
 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/61338
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61338
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 11 Jan 2026 00:44:12 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61338#pullrequestreview-3647371411
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61338#pullrequestreview-3648062150
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61338#pullrequestreview-3648393279
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61338#pullrequestreview-3649856494
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-15T21:50:02Z: https://ci.nodejs.org/job/node-test-pull-request/70820/
- Querying data for job/node-test-pull-request/70820/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61338
From https://github.com/nodejs/node
 * branch                  refs/pull/61338/merge -> FETCH_HEAD
✔  Fetched commits as d73c49e8492d..384466685dae
--------------------------------------------------------------------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty



Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.


You are currently cherry-picking commit 384466685d.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)


Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output


nothing added to commit but untracked files present (use "git add" to track)

✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/21049690389

@avivkeller avivkeller added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 16, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 16, 2026
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 16, 2026

Commit Queue failed
- Loading data for nodejs/node/pull/61338
✔  Done loading data for nodejs/node/pull/61338
----------------------------------- PR info ------------------------------------
Title      deps: update ada to 3.4.1 (#61338)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-ada -> nodejs:main
Labels     author ready, needs-ci, dependencies, commit-queue-squash
Commits    1
 - deps: update ada to 3.4.1
Committers 1
 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/61338
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61338
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 11 Jan 2026 00:44:12 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61338#pullrequestreview-3647371411
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61338#pullrequestreview-3648062150
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61338#pullrequestreview-3648393279
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61338#pullrequestreview-3649856494
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-15T23:17:42Z: https://ci.nodejs.org/job/node-test-pull-request/70820/
- Querying data for job/node-test-pull-request/70820/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   9b2ee5f197..a49053ad6d  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - b32ea1f008 doc: add esm and cjs examples to node:v8
 - a49053ad6d doc: add esm and cjs examples to node:v8
--------------------------------------------------------------------------------
HEAD is now at a49053ad6d doc: add esm and cjs examples to node:v8
   ✔  Reset to origin/main
- Downloading patch for 61338
From https://github.com/nodejs/node
 * branch                  refs/pull/61338/merge -> FETCH_HEAD
✔  Fetched commits as a49053ad6df3..384466685dae
--------------------------------------------------------------------------------
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty



Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.


You are currently cherry-picking commit 384466685d.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)


Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output


nothing added to commit but untracked files present (use "git add" to track)

✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/21052084247

@aduh95
Copy link
Contributor

aduh95 commented Jan 17, 2026

Superseded by #61315

@aduh95 aduh95 closed this Jan 17, 2026
@aduh95 aduh95 deleted the actions/tools-update-ada branch January 17, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nodejs-github-bot @aduh95 @lpinca @cjihrig @UlisesGascon @RafaelGSS @avivkeller