watch: re-expose watch flags via execArgv#60665
Open
Han5991 wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60665 +/- ##
==========================================
+ Coverage 89.72% 89.74% +0.01%
==========================================
Files 675 675
Lines 204806 204822 +16
Branches 39355 39353 -2
==========================================
+ Hits 183761 183813 +52
+ Misses 13330 13280 -50
- Partials 7715 7729 +14
🚀 New features to boost your workflow:
|
b228a4a to
3e2a96f
Compare
66da386 to
77e55e6
Compare
Previously, watch-related flags were consumed by the watch mode manager and stripped from the arguments passed to the child process. This commit ensures these flags are preserved in 'process.execArgv' of the watched process by passing them via an internal environment variable. Fixes regression where flag order was not preserved.
77e55e6 to
2447461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #60594
Summary
--watch*flags and pass them to the child throughNODE_WATCH_ARGS.NODE_WATCH_ARGS, prepend the recovered flags toprocess.execArgv, and delete the env var.test/sequential/test-watch-mode-watch-flags.mjsto assert that watch flags show up at the beginning ofprocess.execArgv, accepting both--watch-path valueand--watch-path=valueforms.Testing