lib: deprecate _http_* #58535

bjohansebas · 2025-05-31T19:21:56Z

close #58534

nodejs-github-bot · 2025-05-31T19:22:01Z

Review requested:

@nodejs/http
@nodejs/net

benchmark/http/check_is_http_token.js

jasnell · 2025-05-31T23:22:01Z

@nodejs/http @mcollina

jasnell · 2025-05-31T23:23:48Z

This one might need a Documentation-only deprecation to start. It's likely going to be too disruptive to go straight to a Runtime deprecation. https://github.com/search?type=code&q=%22require%28%27_http%22

dario-piotrowicz

Yay! thanks for doing this! 🫶

(with this all pesky _modules will be runtime deprecated! 💪)

test/parallel/test-warn-http-server-deprecation.js

test/parallel/test-https-server-close-destroy-timeout.js

benchmark/http/check_is_http_token.js

benchmark/http/check_invalid_header_char.js

bjohansebas · 2025-05-31T23:31:09Z

This one might need a Documentation-only deprecation to start. It's likely going to be too disruptive to go straight to a Runtime deprecation. https://github.com/search?type=code&q=%22require%28%27_http%22

Most of them seem to be just forks of Node.js, rather than actually using these undocumented modules.

jasnell · 2025-05-31T23:45:08Z

Most of them seem to be just forks of Node.js....

I wish that were the case. While there are a good number of forks in those search results, it's plain to see that there are a non-trivial number of other projects requiring "_http_common" and friends. We need to assess just how disruptive this will be... but don't get me wrong, I am in favor of deprecated these but it might need to be a slower path. I'd like @nodejs/http folks to weigh in.

codecov · 2025-06-01T00:29:07Z

Codecov Report

❌ Patch coverage is 97.22114% with 143 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (f6464c5) to head (731360d).

Files with missing lines	Patch %	Lines
lib/internal/http/outgoing.js	95.68%	49 Missing and 3 partials ⚠️
lib/internal/http/server.js	96.90%	39 Missing and 4 partials ⚠️
lib/internal/http/client.js	97.36%	28 Missing ⚠️
lib/internal/http/agent.js	97.30%	17 Missing ⚠️
lib/internal/http/incoming.js	99.35%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58535      +/-   ##
==========================================
+ Coverage   89.76%   89.78%   +0.01%     
==========================================
  Files         673      679       +6     
  Lines      203944   204198     +254     
  Branches    39191    39197       +6     
==========================================
+ Hits       183080   183329     +249     
  Misses      13194    13194              
- Partials     7670     7675       +5

Files with missing lines	Coverage Δ
lib/_http_agent.js	`100.00% <100.00%> (+2.69%)`	⬆️
lib/_http_client.js	`100.00% <100.00%> (+2.63%)`	⬆️
lib/_http_common.js	`100.00% <100.00%> (ø)`
lib/_http_incoming.js	`100.00% <100.00%> (+0.64%)`	⬆️
lib/_http_outgoing.js	`100.00% <100.00%> (+4.31%)`	⬆️
lib/_http_server.js	`100.00% <100.00%> (+2.95%)`	⬆️
lib/http.js	`98.83% <100.00%> (ø)`
lib/https.js	`98.22% <100.00%> (ø)`
lib/internal/child_process.js	`95.08% <100.00%> (ø)`
lib/internal/http/common.js	`100.00% <100.00%> (ø)`
... and 8 more

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benchmark/http/check_invalid_header_char.js

dario-piotrowicz · 2025-06-01T21:47:18Z

lib/_http_common.js

+  _checkIsHttpToken,
+  chunkExpression,
+  continueExpression,
+  CRLF, // TODO: Deprecate this.


Suggested change

CRLF, // TODO: Deprecate this.

CRLF,

no need to have a deprecate todo inside a deprecated module right? (and I don't think this is re-exported by the public http module, right?)

test/parallel/test-https-server-close-destroy-timeout.js

bjohansebas · 2025-06-14T18:03:35Z

@nodejs/http what are your recommendations?

Ref nodejs#58535

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

Ref #58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: #59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: nodejs#59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Ref #58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: #59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: nodejs#59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Ref #58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> PR-URL: #59293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

bjohansebas · 2026-01-31T16:18:20Z

cc: @nodejs/tsc @nodejs/http

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels May 31, 2025

bjohansebas added the wip Issues and PRs that are still a work in progress. label May 31, 2025

bjohansebas force-pushed the http_internals branch 2 times, most recently from 11b6878 to 329d0a0 Compare May 31, 2025 20:17

bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 31, 2025

bjohansebas marked this pull request as ready for review May 31, 2025 21:29

bjohansebas requested review from dario-piotrowicz, jasnell and mcollina May 31, 2025 21:29

bjohansebas removed the wip Issues and PRs that are still a work in progress. label May 31, 2025

bjohansebas force-pushed the http_internals branch 2 times, most recently from 0ec4ccc to bd305a8 Compare May 31, 2025 23:17

jasnell reviewed May 31, 2025

View reviewed changes

benchmark/http/check_is_http_token.js Outdated Show resolved Hide resolved

dario-piotrowicz reviewed May 31, 2025

View reviewed changes

dario-piotrowicz reviewed Jun 1, 2025

View reviewed changes

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 30, 2025

lib: docs deprecate _http_*

d8d2df0

Ref nodejs#58535

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

df48e6f

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas mentioned this pull request Jul 31, 2025

lib: docs deprecate _http_* #59293

Merged

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

70c3173

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas added a commit to bjohansebas/node that referenced this pull request Jul 31, 2025

lib: docs deprecate _http_*

e947fb5

Ref nodejs#58535 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

bjohansebas force-pushed the http_internals branch 2 times, most recently from 8b357cc to 8d9177f Compare January 31, 2026 16:14

lib: deprecate _http_*

731360d

bjohansebas force-pushed the http_internals branch from 8d9177f to 731360d Compare January 31, 2026 16:26

RafaelGSS added the needs-citgm PRs that need a CITGM CI run. label Jan 31, 2026

Uh oh!

lib: deprecate _http_* #58535

Are you sure you want to change the base?

lib: deprecate _http_* #58535

Uh oh!

Conversation

bjohansebas commented May 31, 2025

Uh oh!

nodejs-github-bot commented May 31, 2025

Uh oh!

Uh oh!

jasnell commented May 31, 2025

Uh oh!

jasnell commented May 31, 2025

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjohansebas commented May 31, 2025

Uh oh!

jasnell commented May 31, 2025

Uh oh!

codecov bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

dario-piotrowicz Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bjohansebas commented Jun 14, 2025

Uh oh!

bjohansebas commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jun 1, 2025 •

edited

Loading