Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Feb 3, 2026

Enables more strict compiler flags to avoid warnings like this:

external/+http+ncrypto/include/ncrypto/aead.h:22:54: warning: field 'info_' will be initialized after field 'aead_' [-Wreorder-ctor]
   22 |   Aead(const AeadInfo* info, const EVP_AEAD* aead) : info_(info), aead_(aead) {}
      |                                                      ^~~~~~~~~~~  ~~~~~~~~~~~
      |                                                      aead_(aead)  info_(info)
1 warning generated. 

@anonrig anonrig requested review from aduh95 and jasnell February 3, 2026 16:24
@anonrig anonrig force-pushed the yagiz/more-compiler-checks branch 2 times, most recently from 56cf070 to 4300192 Compare February 3, 2026 16:36
@anonrig anonrig force-pushed the yagiz/more-compiler-checks branch from 4300192 to d628ab0 Compare February 3, 2026 17:43
@anonrig
Copy link
Member Author

anonrig commented Feb 3, 2026

cc @jasnell @aduh95 can you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants