re-add removed BignumPointer::bitLength() #28
Merged
+723
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/add-removed-methods
branch
from
3cd407a to
db3b11c
Compare
Member
Author
|
There are more methods removed with that commit. I'll readd them. |
jasnell
approved these changes
Feb 2, 2026
Contributor
|
Those are not in the upstream nodejs/node (or not anymore?), it's unclear what should be the course of action until nodejs/node#61613 (review) is resolved (i.e. should it be upstreamed in nodejs/node first? Or on the contrary, should we ask for thorough reviews here? Or let the two sources diverge?) |
Member
Author
In the current state, it made a breaking change (and removed methods) without having a major version bump. I recommend re-adding them, and we can still continue on the discussion. |
anonrig
force-pushed
the
yagiz/add-removed-methods
branch
from
9a4613e to
2f49999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
47c21db commit mistakenly removed a method added to BignumPointer and broke workerd.
Ref: 47c21db
cc @aduh95