Fix critical buffer overflow vulnerability in fromBigInt function#63
Open
shadowmystical3-ai wants to merge 1 commit intono2chem:masterfrom
Open
Fix critical buffer overflow vulnerability in fromBigInt function#63shadowmystical3-ai wants to merge 1 commit intono2chem:masterfrom
shadowmystical3-ai wants to merge 1 commit intono2chem:masterfrom
Conversation
shadowmystical3-ai
commented
Mar 10, 2026
- Fixes CVE security issue: Buffer overflow in bigint-buffer native module
- Problem: The stack allocation check only validated word count (word_width_bytes) but the actual memset/malloc used byte_width + overflow_len, causing overflow when large numbers were converted with non-64-bit alignment
- Solution: Changed the stack-fit check to validate the actual allocation size (buffer_size = byte_width + overflow_len) before deciding between stack and heap
- Impact: Prevents potential crash/exploit attacks when processing large BigInt values with non-aligned word widths
- Testing: All existing tests pass with compiled native module
- Fixes CVE security issue: Buffer overflow in bigint-buffer native module - Problem: The stack allocation check only validated word count (word_width_bytes) but the actual memset/malloc used byte_width + overflow_len, causing overflow when large numbers were converted with non-64-bit alignment - Solution: Changed the stack-fit check to validate the actual allocation size (buffer_size = byte_width + overflow_len) before deciding between stack and heap - Impact: Prevents potential crash/exploit attacks when processing large BigInt values with non-aligned word widths - Testing: All existing tests pass with compiled native module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.