Skip to content

Fix critical buffer overflow vulnerability in fromBigInt function#63

Open
shadowmystical3-ai wants to merge 1 commit intono2chem:masterfrom
shadowmystical3-ai:master
Open

Fix critical buffer overflow vulnerability in fromBigInt function#63
shadowmystical3-ai wants to merge 1 commit intono2chem:masterfrom
shadowmystical3-ai:master

Conversation

@shadowmystical3-ai
Copy link

  • Fixes CVE security issue: Buffer overflow in bigint-buffer native module
  • Problem: The stack allocation check only validated word count (word_width_bytes) but the actual memset/malloc used byte_width + overflow_len, causing overflow when large numbers were converted with non-64-bit alignment
  • Solution: Changed the stack-fit check to validate the actual allocation size (buffer_size = byte_width + overflow_len) before deciding between stack and heap
  • Impact: Prevents potential crash/exploit attacks when processing large BigInt values with non-aligned word widths
  • Testing: All existing tests pass with compiled native module

- Fixes CVE security issue: Buffer overflow in bigint-buffer native module
- Problem: The stack allocation check only validated word count (word_width_bytes)
  but the actual memset/malloc used byte_width + overflow_len, causing overflow
  when large numbers were converted with non-64-bit alignment
- Solution: Changed the stack-fit check to validate the actual allocation size
  (buffer_size = byte_width + overflow_len) before deciding between stack and heap
- Impact: Prevents potential crash/exploit attacks when processing large BigInt
  values with non-aligned word widths
- Testing: All existing tests pass with compiled native module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant