Open
Conversation
…ation for contributors about running tests. Adds unit testing with 12 tests. 2 of which will be failing on the upstream nk412/optparse master, but this will be addressed in seprate pull requests. See documentation under CONTRIBUTORS.md. Simple tests use a wrapper and go in tests/optparse.run.bats, while more advanced testing is in tests/optparse.load.bats. Added a testcase for bash's nounset option, which will 'exit 1' when encountering an undefined variable. Optparse1 does not handle nounset properly Added testcase for default values with spaces and special character Added list of current known issues Moved run tests to optparse.run.bats, to reflect this scripts use RUN and not LOAD for testing Added bats load tests, which include optparse directly and build options in each test case, for more advanced test cases Updated docs for test cases Doc updates: added general process workflow, additional goals / features, fixed typo
…uest. Moved the nounset test to bottom, and removed default value with spaces, which are addressed in seperate pull requests. We still fail 2 tests at the end, but that's normal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm making some fixes / enhancements to optparse & created a basic test suite using BATS to ensure everything is working. Would be nice to get this all into master ...
Usage and general process notes are documented in CONTRIBUTORS.md.
It's real easy to use:
apt-get install batsbats tests/Two of the tests will fail, as they're testing for #15 and #17. Everything else should be passing.
I hope this will help spark some more development on optparse. It's a cool little utility, I like it.
If not, I'm gonna fork to erikvip/optparse2 and get all my fixes & the community fixes merged into one branch.
Thanks