Merged
Conversation
- add canonical AGENTS/CONTEXT/copilot/PR template guidance for AI-assisted work\n- enforce quality gates and required governance artifacts via build targets and hooks\n- add boost-style prompt contract, task recipes, and docs/patterns references
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds repository-wide “guardrails” for AI-assisted contributions and build/quality enforcement, plus supporting documentation and bootstrap tooling for new contributors.
Changes:
- Introduces AI contract + architecture boundary docs (
AGENTS.md,CONTEXT.md) and pattern samples underdocs/patterns/. - Adds a two-phase quality gate model via MSBuild targets and a GitHub Actions workflow, plus repo-managed git hooks.
- Adds bootstrap scripts and updates repo configuration (SDK pinning, line endings, tooling versions, docs).
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/bootstrap.sh | POSIX bootstrap script (hooks setup, appsettings local copy, smoke build). |
| scripts/bootstrap.ps1 | PowerShell bootstrap equivalent for Windows. |
| global.json | Pins .NET SDK version and roll-forward policy. |
| docs/patterns/UnitTestPattern.cs | Reference-only unit test pattern sample. |
| docs/patterns/ServicePattern.cs | Reference-only service orchestration pattern sample. |
| docs/patterns/HandlerPattern.cs | Reference-only packet handler pattern sample. |
| docs/patterns/README.md | Index of pattern sample files. |
| docs/orleans.md | Contributor-facing Orleans mental model + repo-specific guidance. |
| Turbo.Runtime/AsyncSignal.cs | Suppresses VSTHRD003 around timeout wait helper. |
| Turbo.Rooms/Wired/WiredPolicy.cs | Removes unused private field. |
| Turbo.Main/Turbo.Main.csproj | Conditionally includes environment appsettings files if present. |
| Turbo.Main/Console/ConsoleCommandService.cs | Suppresses VSTHRD003 around awaiting loop task. |
| Turbo.Catalog/Providers/CatalogSnapshotProvider.cs | Formatting-only change to null-coalescing layout. |
| README.md | Adds repo quickstart + quality model + AI workflow docs. |
| Directory.Build.targets | Adds MSBuild targets for fast check / quality gate + governance file presence checks. |
| Directory.Build.props | Adds AI policy phase properties and WarningsAsErrors configuration. |
| CONTRIBUTING.md | Adds contributor guidance for bootstrap, quality gates, hooks, and AI workflow. |
| CONTEXT.md | Defines architecture boundaries and placement rules. |
| AGENTS.md | Canonical AI-assisted development contract and validation requirements. |
| .gitignore | Stops ignoring scripts/; adjusts plugins-shadow/* ignore entry. |
| .github/workflows/quality.yml | Adds cross-platform CI job running the quality gate target. |
| .github/copilot-instructions.md | Copilot adapter pointing to canonical AI/architecture docs and validation expectations. |
| .githooks/pre-push | Adds repo-managed pre-push hook to run quality gate. |
| .githooks/pre-commit | Adds repo-managed pre-commit hook to run fast checks. |
| .gitattributes | Enforces LF endings for additional repo file types + hooks. |
| .config/dotnet-tools.json | Bumps csharpier tool version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces foundational files and configuration for AI-assisted development, quality gates, and architectural boundaries in the
turbo-cloudrepository. The changes establish a contract-driven workflow for contributors (including AI tools), enforce repository-wide quality standards, and provide guidance for architecture, validation, and review. The most important changes are grouped below:AI Contract, Architecture, and Contribution Guidance
AGENTS.mdas the canonical AI coding contract, detailing skills activation, prompt structure, behavioral rules, task recipes, and validation requirements for AI-assisted changes.CONTEXT.mdto define architecture boundaries, placement rules, data and routing semantics, and pattern references for the repository.CONTRIBUTING.mdto document build/quality gates, toolchain pinning, git hook usage, AI-assisted workflow, and troubleshooting guidance..github/copilot-instructions.mdto adapt the AI contract for Copilot, specifying repository expectations, prompt structure, core constraints, and validation guidance.Quality Gates and Validation
.github/workflows/quality.ymlfor CI quality gate enforcement across platforms, runningTurboCloudQualityGatewith policy phase controls..githooks/pre-commitand.githooks/pre-pushscripts to run fast and full quality checks respectively before commits and pushes. [1] [2].config/dotnet-tools.jsonto bumpcsharpiertool version, ensuring formatting compatibility with quality gates.Directory.Build.propsto add AI policy phase controls, critical warning enforcement, and stricter Orleans diagnostics for contributor safety.Repository Standards
.gitattributesto enforce LF line endings for key file types and repository-managed hooks, improving cross-platform consistency.