Skip to content

Quality/precommit guardrails#6

Merged
billsonnn merged 9 commits intonitrodevco:mainfrom
Diddyy:quality/precommit-guardrails
Feb 8, 2026
Merged

Quality/precommit guardrails#6
billsonnn merged 9 commits intonitrodevco:mainfrom
Diddyy:quality/precommit-guardrails

Conversation

@Diddyy
Copy link
Contributor

@Diddyy Diddyy commented Feb 7, 2026

This pull request introduces foundational files and configuration for AI-assisted development, quality gates, and architectural boundaries in the turbo-cloud repository. The changes establish a contract-driven workflow for contributors (including AI tools), enforce repository-wide quality standards, and provide guidance for architecture, validation, and review. The most important changes are grouped below:

AI Contract, Architecture, and Contribution Guidance

  • Added AGENTS.md as the canonical AI coding contract, detailing skills activation, prompt structure, behavioral rules, task recipes, and validation requirements for AI-assisted changes.
  • Added CONTEXT.md to define architecture boundaries, placement rules, data and routing semantics, and pattern references for the repository.
  • Updated CONTRIBUTING.md to document build/quality gates, toolchain pinning, git hook usage, AI-assisted workflow, and troubleshooting guidance.
  • Added .github/copilot-instructions.md to adapt the AI contract for Copilot, specifying repository expectations, prompt structure, core constraints, and validation guidance.

Quality Gates and Validation

  • Added .github/workflows/quality.yml for CI quality gate enforcement across platforms, running TurboCloudQualityGate with policy phase controls.
  • Introduced .githooks/pre-commit and .githooks/pre-push scripts to run fast and full quality checks respectively before commits and pushes. [1] [2]
  • Updated .config/dotnet-tools.json to bump csharpier tool version, ensuring formatting compatibility with quality gates.
  • Modified Directory.Build.props to add AI policy phase controls, critical warning enforcement, and stricter Orleans diagnostics for contributor safety.

Repository Standards

  • Updated .gitattributes to enforce LF line endings for key file types and repository-managed hooks, improving cross-platform consistency.

- add canonical AGENTS/CONTEXT/copilot/PR template guidance for AI-assisted work\n- enforce quality gates and required governance artifacts via build targets and hooks\n- add boost-style prompt contract, task recipes, and docs/patterns references
Copilot AI review requested due to automatic review settings February 7, 2026 13:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds repository-wide “guardrails” for AI-assisted contributions and build/quality enforcement, plus supporting documentation and bootstrap tooling for new contributors.

Changes:

  • Introduces AI contract + architecture boundary docs (AGENTS.md, CONTEXT.md) and pattern samples under docs/patterns/.
  • Adds a two-phase quality gate model via MSBuild targets and a GitHub Actions workflow, plus repo-managed git hooks.
  • Adds bootstrap scripts and updates repo configuration (SDK pinning, line endings, tooling versions, docs).

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/bootstrap.sh POSIX bootstrap script (hooks setup, appsettings local copy, smoke build).
scripts/bootstrap.ps1 PowerShell bootstrap equivalent for Windows.
global.json Pins .NET SDK version and roll-forward policy.
docs/patterns/UnitTestPattern.cs Reference-only unit test pattern sample.
docs/patterns/ServicePattern.cs Reference-only service orchestration pattern sample.
docs/patterns/HandlerPattern.cs Reference-only packet handler pattern sample.
docs/patterns/README.md Index of pattern sample files.
docs/orleans.md Contributor-facing Orleans mental model + repo-specific guidance.
Turbo.Runtime/AsyncSignal.cs Suppresses VSTHRD003 around timeout wait helper.
Turbo.Rooms/Wired/WiredPolicy.cs Removes unused private field.
Turbo.Main/Turbo.Main.csproj Conditionally includes environment appsettings files if present.
Turbo.Main/Console/ConsoleCommandService.cs Suppresses VSTHRD003 around awaiting loop task.
Turbo.Catalog/Providers/CatalogSnapshotProvider.cs Formatting-only change to null-coalescing layout.
README.md Adds repo quickstart + quality model + AI workflow docs.
Directory.Build.targets Adds MSBuild targets for fast check / quality gate + governance file presence checks.
Directory.Build.props Adds AI policy phase properties and WarningsAsErrors configuration.
CONTRIBUTING.md Adds contributor guidance for bootstrap, quality gates, hooks, and AI workflow.
CONTEXT.md Defines architecture boundaries and placement rules.
AGENTS.md Canonical AI-assisted development contract and validation requirements.
.gitignore Stops ignoring scripts/; adjusts plugins-shadow/* ignore entry.
.github/workflows/quality.yml Adds cross-platform CI job running the quality gate target.
.github/copilot-instructions.md Copilot adapter pointing to canonical AI/architecture docs and validation expectations.
.githooks/pre-push Adds repo-managed pre-push hook to run quality gate.
.githooks/pre-commit Adds repo-managed pre-commit hook to run fast checks.
.gitattributes Enforces LF endings for additional repo file types + hooks.
.config/dotnet-tools.json Bumps csharpier tool version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Diddyy and others added 2 commits February 7, 2026 13:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@billsonnn billsonnn merged commit 01bb166 into nitrodevco:main Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants