Add ApplicationDataValueWrite::SignedInt and UnsignedInt variants.#9
Open
de-vri-es wants to merge 3 commits intoninjasource:mainfrom
Open
Add ApplicationDataValueWrite::SignedInt and UnsignedInt variants.#9de-vri-es wants to merge 3 commits intoninjasource:mainfrom
de-vri-es wants to merge 3 commits intoninjasource:mainfrom
Conversation
de-vri-es
force-pushed
the
support-integer-writes
branch
from
545f377 to
253b784
Compare
de-vri-es
force-pushed
the
support-integer-writes
branch
from
253b784 to
bc4846f
Compare
de-vri-es
force-pushed
the
support-integer-writes
branch
from
46c6978 to
9b4418c
Compare
de-vri-es
force-pushed
the
support-integer-writes
branch
from
bae1f20 to
4733806
Compare
Owner
|
Hey, thanks for your contribution. I really appreciate it. Can you please just write a short description of what you have added so that I don't have to read the code to figure it out. Just a bit more detail than you put in. This will help me answer two questions. Is this change here to get some proprietary device to work that won't benefit anyone else? Is the code written by an human? (it changes the way I review it). No offense intended btw, just the nature of things these days. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
SignedIntandUnsignedIntvariants forApplicationDataValueWriteto support writing integer values.