Conversation
nikobockerman
force-pushed
the
use-basedpyright
branch
from
24bc46b to
c58dc07
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "include": ["**"], | ||
| "typeCheckingMode": "strict" | ||
| "typeCheckingMode": "recommended" |
There was a problem hiding this comment.
PR title indicates switching the type checker (pyright -> basedpyright), but this also relaxes the config from strict to recommended. If the intent is only the tool switch, keep typeCheckingMode as strict; otherwise please update the PR description/title to explicitly call out the change in type-checking strictness (it can materially change what CI catches).
| "include": ["**"], | ||
| "exclude": ["aoc-main/", "solvers/cpp/cmake-conan/", "solvers/python/"], | ||
| "typeCheckingMode": "strict" | ||
| "typeCheckingMode": "recommended" |
There was a problem hiding this comment.
This changes typeCheckingMode from strict to recommended in addition to swapping to basedpyright. If the PR is only intended to switch tooling, consider keeping strict; if loosening is intended, please call it out explicitly since it changes the CI contract for the repo root type-check.
| { | ||
| "include": ["**"], | ||
| "typeCheckingMode": "strict" | ||
| "typeCheckingMode": "recommended" |
There was a problem hiding this comment.
In addition to switching to basedpyright, this relaxes typeCheckingMode from strict to recommended. If the goal is purely switching the checker binary, consider leaving this as strict; otherwise please document the intentional reduction in strictness in the PR description/title because it affects what failures CI will report.
No description provided.