fix(LoginController): guard dispatch against null user#1367
Merged
Conversation
solracsf
force-pushed
the
fixUserNullError
branch
3 times, most recently
from
bec8dc3 to
6f08019
Compare
julien-nc
requested changes
Mar 10, 2026
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Thank you for the fix!
Could you list exactly all the changes you made in the PR comment?
It would be helpful to have a few comments in the code as well.
solracsf
force-pushed
the
fixUserNullError
branch
from
6f08019 to
ad4e054
Compare
Member
Author
|
Reverted all changes beside the real fix & some code cleanup and error handling. |
solracsf
force-pushed
the
fixUserNullError
branch
from
ad4e054 to
289e239
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event dispatch was called unconditionally, assuming a new user had just been created, causing a fatal TypeError:
OCP\User\Events\UserCreatedEvent::__construct(): Argument #1 ($user) must be of type OCP\IUser, null givenRegression from #1353
(
$userwill always be null if'disable_account_creation' => true,)