Skip to content

feat: Show draft message in case the conversation has one attached to it#5981

Merged
AndyScherzinger merged 1 commit intomasterfrom
feat/noid/displayDraftInConversationList
Mar 20, 2026
Merged

feat: Show draft message in case the conversation has one attached to it#5981
AndyScherzinger merged 1 commit intomasterfrom
feat/noid/displayDraftInConversationList

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Mar 19, 2026

also fixing the issue that before when fetching the conversations from the server, the server-state has been exposed to the UI, not the upserted state from DB including the client-side only data.

🖼️ Screenshots

yellow

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 19, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request design Related to the design 3. to review Waiting for reviews feature: conversations 📄 labels Mar 19, 2026
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :) If parity with whatsapp is the goal here, as a follow up we can consider "bubbling up" the conversation in the conversation list when you exit the conversation. It's definitely a follow up if we want to implement it, this looks really nice :)

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/displayDraftInConversationList branch from a2c4ffa to 82683f6 Compare March 19, 2026 14:44
also fixing the issue that before when fetching the conversations from the server, the server-state has been exposed to the UI, not the upserted state from DB including the client-side only data.

AI-assistant: Claude Code v2.1.76 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/displayDraftInConversationList branch from 82683f6 to e8c35fc Compare March 19, 2026 16:31
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5981.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi
Copy link
Collaborator

mahibi commented Mar 20, 2026

Should we modify the time?
I see other messengers show the time when the draft was created.
I'm not sure yet what time i expect there but i guess adapting to other messengers makes sense..?

@AndyScherzinger
Copy link
Member Author

Should we modify the time?
I see other messengers show the time when the draft was created.
I'm not sure yet what time i expect there but i guess adapting to other messengers makes sense..?

Matches @nimishavijay's comment, but we currently lack a timestamp. Will add it in a follow-up and respect that timestamp in the sorting logic 👍

@AndyScherzinger AndyScherzinger merged commit 04694ca into master Mar 20, 2026
17 of 21 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/noid/displayDraftInConversationList branch March 20, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: conversations 📄

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants